[LLVM] Add maintainers for SandboxIR and SandboxVectorizer #115896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vporpo
approved these changes
Nov 12, 2024
Contributor
vporpo
left a comment
vporpo
left a comment
There was a problem hiding this comment.
Sounds good to me, I agree it's better to list two maintainers than just one. We can always update the maintainers list as the project progresses.
slackito
approved these changes
Nov 12, 2024
Collaborator
slackito
left a comment
slackito
left a comment
There was a problem hiding this comment.
Sounds good to me too.
aeubanks
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently looking through some recently added components, and noticed that SandboxIR/SandboxVec don't have a listed maintainer. I'd like to propose @vporpo and @slackito as the maintainers for this component. @vporpo is the one who originally proposed this and drives most of the implementation effort. @slackito is the second most active contributor.
(I'm proposing two maintainers here as these are large components, let me know if I should reduce this to just one.)